openedx / frontend-lib-content-components

[Moved to openedx/frontend-app-course-authoring] A library of high-level components for content handling (viewing, editing, etc. of HTML, video, problems, etc.), to be shared by multiple MFEs.
GNU Affero General Public License v3.0
11 stars 33 forks source link

fix: correct typo in Alert component prop #494

Closed milad-emami closed 3 months ago

milad-emami commented 4 months ago

Corrected the typo in the prop name of the Alert component from 'varaint' to 'variant'. This change ensures the proper functioning of the alert in informational variant.

openedx-webhooks commented 4 months ago

Thanks for the pull request, @milad-emami!

What's next?

Please work through the following steps to get your changes ready for engineering review:

:radio_button: Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

:radio_button: Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

:radio_button: Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

:radio_button: Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.97%. Comparing base (9bce0a3) to head (d9545f4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #494 +/- ## ======================================= Coverage 88.97% 88.97% ======================================= Files 248 248 Lines 4545 4545 Branches 936 940 +4 ======================================= Hits 4044 4044 Misses 468 468 Partials 33 33 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

e0d commented 3 months ago

@KristinAoki @milad-emami doesn't have merge access, are you happy to merge for them?

openedx-webhooks commented 3 months ago

@milad-emami 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.