search

openedx / frontend-lib-content-components

[Moved to openedx/frontend-app-course-authoring] A library of high-level components for content handling (viewing, editing, etc. of HTML, video, problems, etc.), to be shared by multiple MFEs.
GNU Affero General Public License v3.0
11 stars 33 forks source link

fix: remove imports breaking build #500

Closed KristinAoki closed 3 months ago

KristinAoki commented 3 months ago

This PR removes paragon scss variable imports from .scss files. These imports break the build of the course authoring MFE because of a ModuleErrorBuild. The only variable used is $gray-500 and the hex code for the variable is the same in the openedX and edX themes, #707070, so replacement will have no affect on the UI

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.91%. Comparing base (beb4813) to head (295008e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #500 +/- ## ======================================= Coverage 88.91% 88.91% ======================================= Files 248 248 Lines 4554 4554 Branches 943 939 -4 ======================================= Hits 4049 4049 Misses 472 472 Partials 33 33 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bradenmacdonald commented 3 months ago

If you prefer to keep the variables, I think https://github.com/open-craft/frontend-lib-content-components/commit/5ff22c1ee6cdbbb98d8578a1313ddb08cbd4b873 would fix the error; assuming it's the same as a similar error I recently saw. This fix seems fine too though.