search

openedx / frontend-lib-content-components

[Moved to openedx/frontend-app-course-authoring] A library of high-level components for content handling (viewing, editing, etc. of HTML, video, problems, etc.), to be shared by multiple MFEs.
GNU Affero General Public License v3.0
11 stars 33 forks source link

refactor: remove thumbnail for non-edX videos & allow removing fallback URLs #505

Closed bra-i-am closed 2 months ago

bra-i-am commented 2 months ago

Description

This PR aims to solve the issue https://github.com/openedx/frontend-app-course-authoring/issues/1016 by showing the thumbnail from the videoSettingsModal only when the Video ID is one given by edX according to this method

image

Any other Video ID will hide the thumbnail:

image

Additionally, this PR fixes a bug when trying to delete a Fallback video URL:

image

openedx-webhooks commented 2 months ago

Thanks for the pull request, @bra-i-am!

What's next?

Please work through the following steps to get your changes ready for engineering review:

:radio_button: Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

:radio_button: Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

:radio_button: Submit a signed contributor agreement (CLA)

:warning: We ask all contributors to the Open edX project to submit a signed contributor agreement or indicate their institutional affiliation. Please see the CONTRIBUTING file for more information.

If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by adding a comment below that you have signed it. If the CLA check continues to fail, you can tag the @openedx/cla-problems team in a comment for further assistance.

:radio_button: Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

:radio_button: Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

bradenmacdonald commented 2 months ago

@bra-i-am Thanks for contributing the fix! We've just moved this repo into https://github.com/openedx/frontend-app-course-authoring/ though; would you mind opening the same fix PR against that repo? Sorry for the extra work.

openedx-webhooks commented 2 months ago

@bra-i-am Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

bra-i-am commented 2 months ago

hey @bradenmacdonald, thanks for your answer. It's no problem. I already created the PR there: https://github.com/openedx/frontend-app-course-authoring/pull/1241