feat: updated jest to v29 & frontend-build major version upgrade

openedx / frontend-platform

A framework for Open edX micro-frontend applications.

http://openedx.github.io/frontend-platform

GNU Affero General Public License v3.0

32 stars 64 forks source link

feat: updated jest to v29 & frontend-build major version upgrade #661

Closed BilalQamar95 closed 6 months ago

BilalQamar95 commented 8 months ago

Description:

Updated jest to v29 & frontend-build major version upgrade

BREAKING CHANGE: Due to peerDependency upgrade of frontend-build this goes as a breaking change

Merge checklist:

[ ] Consider running your code modifications in the included example app within frontend-platform. This can be done by running npm start and opening http://localhost:8080.
[ ] Consider testing your code modifications in another local micro-frontend using local aliases configured via the module.config.js file in frontend-build.
[ ] Verify your commit title/body conforms to the conventional commits format (e.g., fix, feat) and is appropriate for your code change. Consider whether your code is a breaking change, and modify your commit accordingly.

Post merge:

[ ] After the build finishes for the merged commit, verify the new release has been pushed to NPM.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.41%. Comparing base (441800f) to head (4a0f519). Report is 5 commits behind head on alpha.

:exclamation: Current head 4a0f519 differs from pull request most recent head aa2169e. Consider uploading reports for the commit aa2169e to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## alpha #661 +/- ## ========================================== - Coverage 83.50% 83.41% -0.10% ========================================== Files 40 40 Lines 1073 1073 Branches 197 197 ========================================== - Hits 896 895 -1 - Misses 165 166 +1 Partials 12 12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

arbrandes commented 7 months ago

Can you modify this to use the latest frontend-build alpha, and then rebase the PR on this repo's alpha branch?

BilalQamar95 commented 7 months ago

Can you modify this to use the latest frontend-build alpha, and then rebase the PR on this repo's alpha branch?

@arbrandes I have updated it to use frontend-build alpha & rebased the PR to alpha branch of this repo

jristau1984 commented 7 months ago

@arbrandes can you please respond to the question above? We would like to move this forward if there are no more concerns. Thanks!