Closed johnvente closed 6 months ago
Thanks for the pull request, @johnvente! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.
Attention: Patch coverage is 88.78505%
with 12 lines
in your changes are missing coverage. Please review.
Project coverage is 83.98%. Comparing base (
441800f
) to head (b72e103
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@johnvente Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.
Description:
This PR the basic
PluggableComponent
which will allow to reuse it where we need it and an util calledcontextFactory
will help us to have a context provider that we will use thro a reducer to share data between components or even PluggableComponent if you rather. The main idea is to have those to be reusable in any MFE that way we don't need to setup them.This PR depends on this one: https://github.com/openedx/frontend-build/pull/518
How to test it
Merge checklist:
frontend-platform
. This can be done by runningnpm start
and opening http://localhost:8080.module.config.js
file infrontend-build
.fix
,feat
) and is appropriate for your code change. Consider whether your code is a breaking change, and modify your commit accordingly.Post merge: