search

openedx / frontend-platform

A framework for Open edX micro-frontend applications.
http://openedx.github.io/frontend-platform
GNU Affero General Public License v3.0
32 stars 64 forks source link

build: upgrade codecov from v3 to v4, use secret #692

Closed kdmccormick closed 5 months ago

kdmccormick commented 6 months ago

Per https://openedx.atlassian.net/wiki/spaces/COMM/pages/3438280709/Adding+Codecov, I think this is the right thing to do.

@dcoa , could you review this?

kdmccormick commented 6 months ago

Hm, the Run Coverage step says:

Error: Codecov token not found. Please provide Codecov token with -t flag.
dcoa commented 6 months ago

There is a second file that uses codecov too, manual-publish.yml

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.41%. Comparing base (de09872) to head (877f51f). Report is 19 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #692 +/- ## ========================================== - Coverage 83.50% 83.41% -0.10% ========================================== Files 40 40 Lines 1073 1073 Branches 197 197 ========================================== - Hits 896 895 -1 - Misses 165 166 +1 Partials 12 12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kdmccormick commented 5 months ago

@dcoa how does this look?