Closed bradenmacdonald closed 4 months ago
Thanks for the pull request, @bradenmacdonald! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 83.41%. Comparing base (
9d2e727
) to head (d331922
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
The
global
keyword is a non-standard NodeJS specific keyword. But since 2019, we can useglobalThis
instead, which works in every runtime. For example,globalThis
has the same consistent meaning in both browsers and NodeJS, whereasglobal
does not work in browsers unless you use some build process to rewrite it towindow
.Details: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/globalThis#description
Example from Chrome console: