Closed bradenmacdonald closed 2 months ago
Thanks for the pull request, @bradenmacdonald!
Please work through the following steps to get your changes ready for engineering review:
If you haven't already, check this list to see if your contribution needs to go through the product review process.
To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
This PR must be merged before / after / at the same time as ...
This PR is waiting for OEP-1234 to be accepted.
This PR must be merged by XX date because ...
This is for a course on edx.org.
If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.
This repository is currently maintained by @openedx/committers-frontend
. Tag them in a comment and let them know that your changes are ready for review.
If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
Our goal is to get community contributions seen and reviewed as efficiently as possible.
However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 83.41%. Comparing base (
751a691
) to head (72b2b3c
). Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@arbrandes - I'd love to hear your thoughts on this (is there a non-obvious reason we'd need to keep these deps around?)
@brian-smith-tcril @arbrandes I'm planning to hit merge on this PR tomorrow - let me know if you have any objections.
This makes sense to me. 👍
@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
core-js
andregenerator-runtime
are marked as a development dependencies (for the test suites), but the tests actually pass fine without them. I think they should just be removed.Context: they are compatibility layers for older browsers/runtimes, and aren't needed in 2024.