openedx / frontend-platform

A framework for Open edX micro-frontend applications.
http://openedx.github.io/frontend-platform
GNU Affero General Public License v3.0
32 stars 64 forks source link

chore: remove core-js and regenerator-runtime #702

Closed bradenmacdonald closed 2 months ago

bradenmacdonald commented 5 months ago

core-js and regenerator-runtime are marked as a development dependencies (for the test suites), but the tests actually pass fine without them. I think they should just be removed.

Context: they are compatibility layers for older browsers/runtimes, and aren't needed in 2024.

openedx-webhooks commented 5 months ago

Thanks for the pull request, @bradenmacdonald!

What's next?

Please work through the following steps to get your changes ready for engineering review:

:radio_button: Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

:radio_button: Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

:radio_button: Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

:radio_button: Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/committers-frontend. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.41%. Comparing base (751a691) to head (72b2b3c). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #702 +/- ## ======================================= Coverage 83.41% 83.41% ======================================= Files 40 40 Lines 1073 1073 Branches 197 197 ======================================= Hits 895 895 Misses 166 166 Partials 12 12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

brian-smith-tcril commented 4 months ago

@arbrandes - I'd love to hear your thoughts on this (is there a non-obvious reason we'd need to keep these deps around?)

bradenmacdonald commented 2 months ago

@brian-smith-tcril @arbrandes I'm planning to hit merge on this PR tomorrow - let me know if you have any objections.

davidjoy commented 2 months ago

This makes sense to me. 👍

openedx-webhooks commented 2 months ago

@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.