openedx / frontend-platform

A framework for Open edX micro-frontend applications.
http://openedx.github.io/frontend-platform
GNU Affero General Public License v3.0
32 stars 64 forks source link

chore: define app entry point for webpack.dev.config.js #726

Closed adamstankiewicz closed 2 months ago

adamstankiewicz commented 2 months ago

Description:

Without defining the app entrypoint explicitly, HtmlWebpackPlugin does not have assets available for app when its referenced in the chunks option.

The webpack.common.config.js in frontend-build defines an app entrypoint, but the frontend-platform example app overrides it.

Merge checklist:

Post merge:

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.41%. Comparing base (c878cce) to head (20deb19). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #726 +/- ## ======================================= Coverage 83.41% 83.41% ======================================= Files 40 40 Lines 1073 1073 Branches 197 197 ======================================= Hits 895 895 Misses 166 166 Partials 12 12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.