search

openedx / frontend-plugin-framework

An experimental framework for micro-frontend plugins.
GNU Affero General Public License v3.0
6 stars 12 forks source link

fix: remove header and footer dependencies #61

Closed brian-smith-tcril closed 6 months ago

brian-smith-tcril commented 6 months ago

these were only used within the example apps, it doesn't make sense to have them as dependencies of the framework itself

verified working here https://github.com/openedx/frontend-app-account/pull/1044

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.53%. Comparing base (9be2cd4) to head (2754c56). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #61 +/- ## ======================================= Coverage 96.53% 96.53% ======================================= Files 10 10 Lines 173 173 Branches 35 35 ======================================= Hits 167 167 Misses 5 5 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

openedx-semantic-release-bot commented 6 months ago

:tada: This PR is included in version 1.1.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: