openedx / i18n-tools

Tools to help with internationalization and localization of Open edX projects
Apache License 2.0
26 stars 31 forks source link

Use django-admin instead of django-admin.py #122

Closed toxinu closed 1 year ago

toxinu commented 1 year ago

Django 3.0 deprecated the django-admin.py command and Django 4.0 removed it in favor of django-admin.

https://docs.djangoproject.com/en/4.1/releases/4.0/

openedx-webhooks commented 1 year ago

Thanks for the pull request, @toxinu! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

pomegranited commented 1 year ago

@toxinu This change is working fine! I'm not sure about whether the formatting changes are welcome (unsure about the lint tests that might be run for this repo?), but we can let upstream decide on that.

@Carlos-Muniz since you are the CC most acquainted with the language translation tools, would you be able to help us get this change merged? Since django-admin.py was deprecated in Django 3, but not removed until Django 4, and edx-platform is using Django 3, there's no huge rush here, but it's a low-risk change to apply.

:+1:

toxinu commented 1 year ago

@pomegranited Thanks for your review. I didn't want to commit the formatting changes (I just had black running automatically). So I have updated the changes and rewritten the git history without the formatting changes.

codecov[bot] commented 1 year ago

Codecov Report

Base: 90.31% // Head: 91.07% // Increases project coverage by +0.76% :tada:

Coverage data is based on head (7460ec5) compared to base (2b229f5). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #122 +/- ## ========================================== + Coverage 90.31% 91.07% +0.76% ========================================== Files 9 10 +1 Lines 351 381 +30 Branches 31 35 +4 ========================================== + Hits 317 347 +30 Misses 33 33 Partials 1 1 ``` | [Impacted Files](https://codecov.io/gh/openedx/i18n-tools/pull/122?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx) | Coverage Ξ” | | |---|---|---| | [tests/\_\_init\_\_.py](https://codecov.io/gh/openedx/i18n-tools/pull/122?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-dGVzdHMvX19pbml0X18ucHk=) | `100.00% <0.00%> (ΓΈ)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

pomegranited commented 1 year ago

Thanks for getting these tests running @mphilbrick211 and @e0d ! Who's the best person/team to ping to get this reviewed and merged?

mphilbrick211 commented 1 year ago

Hi @kashifch! Would you mind taking a look at this for review/merge? I believe you are the owner of this repo. Thank you!

pomegranited commented 1 year ago

Thank you @Carlos-Muniz ! Hi @kashifch , can you help us get this merged? CC @mphilbrick211

mphilbrick211 commented 1 year ago

Hi @kashifch - friendly follow-up on getting this merged :)

mphilbrick211 commented 1 year ago

Hi @kashifch - friendly ping on this :)

pomegranited commented 1 year ago

Thank you for keeping the communication going here, @mphilbrick211 :)

@Carlos-Muniz Would you be willing to add this repo as part of your core contributor merge rights, given your experience and efforts on internationalization and translations? I'm happy to nominate you, and/or define a "i18n CC repos group". CC @sarina

sarina commented 1 year ago

@pomegranited - I think an i18n CC repos group makes sense. Unfortunately, Carlos has moved on from his position at tCRIL. It would not be a bad idea to try to identify others who could at least assist with issues in these repos.

sarina commented 1 year ago

Actually - @kashifch I understand this change and will be merging it tomorrow unless you disagree. Thanks!

openedx-webhooks commented 1 year ago

@toxinu πŸŽ‰ Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

toxinu commented 1 year ago

Thanks, everybody for helping and merging this pull request. πŸ˜ƒ 🎊