Closed shadinaif closed 1 year ago
Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
Please review @OmarIthawi @brian-smith-tcril
Patch coverage: 100.00
% and project coverage change: +8.39
:tada:
Comparison is base (
723a0fb
) 91.07% compared to head (da854b2
) 99.47%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
a linter test is failing because run
method is too long, I'll fix it after we decide what to do with the code review above
@mphilbrick211 it looks like this repo isn't on the spreadsheet at all, it's also not in backstage. Do you know who I should ping on this?
@AliAdnanSohail - would you mind reviewing this, and merging if all looks good? Thanks!
cc: @brian-smith-tcril
@shadinaif 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
After multiple discussions, and as part of FC-0012 project project; the team decided to always remove
POT-Creation-Date
from translation extraction (fromextract
command). The reason is that this metadata is causing openedx-translations repo to generate too many useless commits that differ only in Creation Date in related files (see example commits here)This PR will also activate tests for
extract
script that have been skipped a long time ago because it was part ofedx-platform