openedx / i18n-tools

Tools to help with internationalization and localization of Open edX projects
Apache License 2.0
26 stars 31 forks source link

Always remove POT-Creation-Date metadata #129

Closed shadinaif closed 1 year ago

shadinaif commented 1 year ago

After multiple discussions, and as part of FC-0012 project project; the team decided to always remove POT-Creation-Date from translation extraction (from extract command). The reason is that this metadata is causing openedx-translations repo to generate too many useless commits that differ only in Creation Date in related files (see example commits here)

This PR will also activate tests for extract script that have been skipped a long time ago because it was part of edx-platform

openedx-webhooks commented 1 year ago

Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

shadinaif commented 1 year ago

Please review @OmarIthawi @brian-smith-tcril

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +8.39 :tada:

Comparison is base (723a0fb) 91.07% compared to head (da854b2) 99.47%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #129 +/- ## ========================================== + Coverage 91.07% 99.47% +8.39% ========================================== Files 10 10 Lines 381 381 Branches 29 28 -1 ========================================== + Hits 347 379 +32 + Misses 33 0 -33 - Partials 1 2 +1 ``` | [Impacted Files](https://app.codecov.io/gh/openedx/i18n-tools/pull/129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx) | Coverage Δ | | |---|---|---| | [tests/test\_extract.py](https://app.codecov.io/gh/openedx/i18n-tools/pull/129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-dGVzdHMvdGVzdF9leHRyYWN0LnB5) | `98.00% <100.00%> (+64.00%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

shadinaif commented 1 year ago

a linter test is failing because run method is too long, I'll fix it after we decide what to do with the code review above

brian-smith-tcril commented 1 year ago

@mphilbrick211 it looks like this repo isn't on the spreadsheet at all, it's also not in backstage. Do you know who I should ping on this?

mphilbrick211 commented 1 year ago

@AliAdnanSohail - would you mind reviewing this, and merging if all looks good? Thanks!

cc: @brian-smith-tcril

openedx-webhooks commented 1 year ago

@shadinaif 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.