openedx / i18n-tools

Tools to help with internationalization and localization of Open edX projects
Apache License 2.0
26 stars 31 forks source link

feat: refactor extract command with its tests #135

Closed shadinaif closed 1 year ago

shadinaif commented 1 year ago

Refactor for more usability and readability. And to prepare tests to deal with options to be added to extract command in future pull-requests

Change log?

None, just a code refactor

openedx-webhooks commented 1 year ago

Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

shadinaif commented 1 year ago

This one is ready @OmarIthawi , @brian-smith-tcril

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.27% :tada:

Comparison is base (c3a9831) 99.47% compared to head (d7baf2c) 99.74%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #135 +/- ## ========================================== + Coverage 99.47% 99.74% +0.27% ========================================== Files 10 10 Lines 381 399 +18 Branches 28 27 -1 ========================================== + Hits 379 398 +19 + Partials 2 1 -1 ``` | [Files Changed](https://app.codecov.io/gh/openedx/i18n-tools/pull/135?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx) | Coverage Δ | | |---|---|---| | [tests/test\_extract.py](https://app.codecov.io/gh/openedx/i18n-tools/pull/135?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-dGVzdHMvdGVzdF9leHRyYWN0LnB5) | `100.00% <100.00%> (+2.00%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

openedx-webhooks commented 1 year ago

@shadinaif 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.