Closed shadinaif closed 1 year ago
Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
All modified lines are covered by tests :white_check_mark:
Comparison is base (
ac49869
) 99.77% compared to head (f1ba793
) 99.78%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Ready for review @OmarIthawi @brian-smith-tcril
Thanks @shadinaif!! Some tests are failing. Would you mind taking a look?
Also I think it makes sense to have an integration test case which runs the following two commands on a sample repo test folder:
cd tests/data/mock-django-app
# Needs some python files to generate languages for
i18n_tool extract
i18n_tool validate
I think this will ensure that this error will not happen again, what do you think?
@OmarIthawi any thing left in this PR ? waiting for new release to unblock credentials.
Thanks for checking @awais786. We need someone to test it on the credentials repo, I couldn't get to this in a timely manner.
Justin was going to test it, but please feel free to do so.
If it's good, I can merge and cut a new release.
@OmarIthawi https://github.com/openedx/credentials/pull/2221 plz check this. Seems trans are working,
now credentials failing with black issue. I have fixed black path in credential so all set good to go.
black --check .
would reformat /home/runner/work/credentials/credentials/src/edx-i18n-tools/i18n/branch_cleanup.py
would reformat /home/runner/work/credentials/credentials/src/edx-i18n-tools/i18n/__init__.py
would reformat /home/runner/work/credentials/credentials/src/edx-i18n-tools/i18n/changed.py
would reformat /home/runner/work/credentials/credentials/src/edx-i18n-tools/i18n/converter.py
would reformat /home/runner/work/credentials/credentials/src/edx-i18n-tools/i18n/config.py
would reformat /home/runner/work/credentials/credentials/src/edx-i18n-tools/i18n/execute.py
would reformat /home/runner/work/credentials/credentials/src/edx-i18n-tools/i18n/dummy.py
would reformat /home/runner/work/credentials/credentials/src/edx-i18n-tools/i18n/extract.py
would reformat /home/runner/work/credentials/credentials/src/edx-i18n-tools/i18n/generate.py
would reformat /home/runner/work/credentials/credentials/src/edx-i18n-tools/i18n/main.py
would reformat /home/runner/work/credentials/credentials/src/edx-i18n-tools/i18n/segment.py
would reformat /home/runner/work/credentials/credentials/src/edx-i18n-tools/i18n/transifex.py
would reformat /home/runner/work/credentials/credentials/src/edx-i18n-tools/scripts/podup.py
would reformat /home/runner/work/credentials/credentials/src/edx-i18n-tools/setup.py
would reformat /home/runner/work/credentials/credentials/src/edx-i18n-tools/i18n/validate.py
would reformat /home/runner/work/credentials/credentials/src/edx-i18n-tools/tests/__init__.py
would reformat /home/runner/work/credentials/credentials/src/edx-i18n-tools/tests/test_config.py
would reformat /home/runner/work/credentials/credentials/src/edx-i18n-tools/tests/test_changed.py
would reformat /home/runner/work/credentials/credentials/src/edx-i18n-tools/tests/test_converter.py
would reformat /home/runner/work/credentials/credentials/src/edx-i18n-tools/tests/test_dummy.py
would reformat /home/runner/work/credentials/credentials/src/edx-i18n-tools/tests/test_extract.py
would reformat /home/runner/work/credentials/credentials/src/edx-i18n-tools/tests/test_generate.py
would reformat /home/runner/work/credentials/credentials/src/edx-i18n-tools/tests/test_integration.py
would reformat /home/runner/work/credentials/credentials/src/edx-i18n-tools/tests/test_transifex.py
would reformat /home/runner/work/credentials/credentials/src/edx-i18n-tools/tests/test_segment.py
would reformat /home/runner/work/credentials/credentials/src/edx-i18n-tools/tests/test_validate.py
I wasn't able to get to this yesterday. I tried it out this morning and I was able to validate translations locally without any further issues. Thanks for the work on this!
@OmarIthawi plz release new version.
@awais786 That's interesting... Black shouldn't be trying to reformat the files of an external library. 🤔 Worst case maybe we just need to update pyproject.toml
to ensure it's properly excluding directories? Or maybe it's a symptom of how the library was installed?
Either way, that problem is definitely on the Credentials side and I'm sure we can figure out a way to work around it.
@awais786 That's interesting... Black shouldn't be trying to reformat the files of an external library. 🤔 Worst case maybe we just need to update
pyproject.toml
to ensure it's properly excluding directories? Or maybe it's a symptom of how the library was installed?Either way, that problem is definitely on the Credentials side and I'm sure we can figure out a way to work around it.
I have already fixed https://github.com/openedx/credentials/pull/2221
@shadinaif 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
@awais786 thanks for the review and the release cut. I was about to merge and cut the release, but you've beat me to it.
Thanks again for the thorough report! It's making this tool much better :)
@OmarIthawi Thanks for the quick fix.
External packages are forcing validation on
PO-Revision-Date
. Therefore, we are restoring bothPOT-Creation-Date
andPO-Revision-Date
but setting a fixed value for them to avoid having a lot of false (git diff) lines. Note: (2023-06-13 is Palm release date)This is a fix for a defect reported in
credentials
repository: https://github.com/openedx/i18n-tools/issues/131Reverts part of the work done here https://github.com/openedx/i18n-tools/pull/129
This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.