Enforce OEP-1 clause that all OEPs should be merged even if rejected/withdrawn

openedx / open-edx-proposals

Proposals for Open edX architecture, best practices and processes

http://open-edx-proposals.readthedocs.io/

Other

43 stars 32 forks source link

Enforce OEP-1 clause that all OEPs should be merged even if rejected/withdrawn #428

Open kdmccormick opened 2 years ago

kdmccormick commented 2 years ago

OEP-1 says that you shouldn't close an OEP PR - you should instead merge it, utilizing the "withdrawn" or "rejected" statuses.
We should clarify this with folks, and demonstrate it by merging in a few rejected/abandoned OEP PRs that were initially closed instead of merged.
Should do openedx/open-edx-proposals#427 first though.

kdmccormick commented 1 year ago

Unassigning myself as I have no current plans to do this.

sarina commented 1 month ago

@kdmccormick for this one, would you suggest I go through all unmerged PRs and reopen and merge them with an appropriate status?

kdmccormick commented 1 month ago

That's what OEP-1 says to do. Personally, I think it's a little silly. If I wanted to know the rejected OEPs, I could just look at closed PRs.

sarina commented 1 month ago

I think I do see the sense in it, because most people don't go through closed PRs. I think I'll take this on

sarina commented 3 days ago

Ultimately I agree with you, @kdmccormick . I don't think it's worth the time to merge PRs that never materialized. I updated OEP-1 accordingly and discussion can continue on #601