search

openedx / open-edx-proposals

Proposals for Open edX architecture, best practices and processes
http://open-edx-proposals.readthedocs.io/
Other
44 stars 32 forks source link

OEP-66 - update comment_client, add course_roles #556

Closed hsinkoff closed 6 months ago

hsinkoff commented 7 months ago

Description

OEP-66 focuses on authorization best practices and includes descriptions of the currently in use systems. This PR adds additional information to the section on the roles used for discussions (django_comment_client_role) and adds an additional section on the proposed course_roles system.

Background

course_roles is intended to be used for course level access. The roles will be based upon permissions and access in the code will be gated by permission instead of role. They are intended to allow for greater flexibility in adding new roles. Information on the project can be found here and the tech spec is here.

To Do

last modified will need to be updated once any changes suggested on the PR are made

feanil commented 6 months ago

This generally looks good to me as well, just had a couple of small questions. Not blocking if you want to leave things as they are.