openedx / open-edx-proposals

Proposals for Open edX architecture, best practices and processes
http://open-edx-proposals.readthedocs.io/
Other
44 stars 31 forks source link

Clarify how devDependencies should be used for NPM packages (OEP-67: Standard Tools and Technologies) #615

Closed bradenmacdonald closed 2 weeks ago

bradenmacdonald commented 1 month ago

Per a discussion with @regisb about how we can speed up MFE build times in Tutor, I want to clarify how dependencies and devDependencies should be used. The goal is that tutor can install MFE dependencies using npm ci --production which would do a fast install that excludes devDependencies. This will be a significant speedup in the case where we can exclude things like Jest (which is a very large and bloated package[^1]) that aren't needed just to build and deploy the MFE.

Note: this is very much not the case now:

[^1]: npx howfat jest says 487 deps, 49.6mb

openedx-webhooks commented 1 month ago

Thanks for the pull request, @bradenmacdonald!

What's next?

Please work through the following steps to get your changes ready for engineering review:

:radio_button: Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

:radio_button: Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

:radio_button: Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

:radio_button: Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @sarina. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

openedx-webhooks commented 2 weeks ago

@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.