Closed bradenmacdonald closed 2 weeks ago
Thanks for the pull request, @bradenmacdonald!
Please work through the following steps to get your changes ready for engineering review:
If you haven't already, check this list to see if your contribution needs to go through the product review process.
To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
This PR must be merged before / after / at the same time as ...
This PR is waiting for OEP-1234 to be accepted.
This PR must be merged by XX date because ...
This is for a course on edx.org.
If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.
This repository is currently maintained by @sarina
. Tag them in a comment and let them know that your changes are ready for review.
If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
Our goal is to get community contributions seen and reviewed as efficiently as possible.
However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.
@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
Per a discussion with @regisb about how we can speed up MFE build times in Tutor, I want to clarify how
dependencies
anddevDependencies
should be used. The goal is that tutor can install MFE dependencies usingnpm ci --production
which would do a fast install that excludesdevDependencies
. This will be a significant speedup in the case where we can exclude things like Jest (which is a very large and bloated package[^1]) that aren't needed just to build and deploy the MFE.Note: this is very much not the case now:
frontend-build
includes Jest, eslint, TypeScript, react-dev-utils, and more independencies
, and puts@babel/preset-typescript
which I think is required for build indevDependencies
course-authoring
MFE putsfrontend-build
andaxios
asdevDependencies
frontend-build
as a devDependencyjest
,@testing-library/user-event
, andredux-devtools-extension
asdependencies
while putting@openedx/frontend-build
as a devDependency[^1]:
npx howfat jest
says487 deps, 49.6mb