Closed PavloNetrebchuk closed 1 month ago
Thanks for the pull request, @PavloNetrebchuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
Hi @PavloNetrebchuk, thanks for these changes. They look really good overall. I've noted all the minor visual issues I could find below. This is a huge usability/experience win regardless of these issues, so if any are difficult to resolve, most of them could be saved for a future cleanup.
iOS:
Android:
Both iOS and Android:
Hello, @sdaitzman I made the changes based on your feedback and changed screenshots and videos in the PR description.
Thanks so much @PavloNetrebchuk, these improvements look great!
Reviewing
@omerhabib26 @k1rill friendly reminder on this PR 🙏
Hey @volodymyr-chekyrta, the review is in process and taking some time for no major big change only some code improvements. Hopefully I'll be able to complete its review in a day or two
During the development process, we identified the need to refactor the ProgramsFragment. Link to Issue: https://github.com/openedx/openedx-app-android/issues/325
@PavloNetrebchuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
https://www.figma.com/file/iZ56YMjbRMShCCDxqrqRrR/Open-edX-Mobile-App-All-Screens-v2.1?type=design&mode=design&t=W1kb1UTSIkmV2qox-0
The drop-down menu is enabled automatically when "Programs" is enabled in the configuration file.
https://github.com/openedx/openedx-app-android/assets/141041606/6a27c320-16b0-4f98-9089-88de531f18ab
https://github.com/openedx/openedx-app-android/assets/141041606/9cbc82b2-0d3d-4268-ad91-41ca17daf2de
Feature enabled by default.
🚨 You should use key:
to enable a list style Dashboard (old style)
API
Since the new APIs are not available in the master branch, please use the sandbox:
During the development process, we identified the need to refactor the ProgramsFragment. Link to Issue: https://github.com/openedx/openedx-app-android/issues/325