openedx-webhooks
commented
2 months ago Thanks for the pull request, @volodymyr-chekyrta! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
- supporting documentation
- Open edX discussion forum threads
- timeline information ("this must be merged by XX date", and why that is)
- partner information ("this is a course on edx.org")
- any other information that can help Product understand the context for the PR
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
volodymyr-chekyrta
Modifier factory functions must use the receiver Modifier instance.
Inspection info:Modifier factory functions are fluently chained to construct a chain of Modifier objects that will be applied to a layout. As a result, each factory function must use the receiver Modifier parameter, to ensure that the function is returning a chain that includes previous items in the chain. Make sure the returned chain either explicitly includes this, such as return this.then(MyModifier) or implicitly by returning a chain that starts with an implicit call to another factory function, such as return myModifier(), where myModifier is defined as fun Modifier.myModifier(): Modifier.