openedx / openedx-app-android

The mobile app for Android for the Open EdX Platform.
Apache License 2.0
14 stars 19 forks source link

feat: [FC-0047] Calendar main screen and dialogs #322

Closed PavloNetrebchuk closed 1 month ago

PavloNetrebchuk commented 1 month ago

https://www.figma.com/design/iZ56YMjbRMShCCDxqrqRrR/Open-edX-Mobile-App-All-Screens-v2.1?node-id=13749-57827&t=1CiKfcW4o1pmVC5G-0

This pull request contains a portion of the FC-0047 scope. We have only added the UI for now. The logic will be added later.


Light Theme Dark Theme
Screenshot 2024-05-20 at 12 52 48 Screenshot 2024-05-20 at 12 53 10
Screenshot 2024-05-20 at 12 53 39 Screenshot 2024-05-20 at 12 53 59
Screenshot 2024-05-20 at 12 55 00 Screenshot 2024-05-20 at 12 55 18
Screenshot 2024-05-20 at 13 01 11 Screenshot 2024-05-20 at 13 01 28
openedx-webhooks commented 1 month ago

Thanks for the pull request, @PavloNetrebchuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

PavloNetrebchuk commented 1 month ago

The CalendarManager and several calendar logic classes were moved to the core module to save the efficiency of the dates tab on the course home screen. We will move them back after adding a new calendar setting and removing the calendar logic from dates tab.

volodymyr-chekyrta commented 1 month ago

@HamzaIsrar12 @k1rill friendly reminder on this PR 🙏 We have to unblock further work.

volodymyr-chekyrta commented 1 month ago

@HamzaIsrar12 @k1rill, please spare some time to review this PR 🙏 We have to unlock further work.

PavloNetrebchuk commented 1 month ago

@k1rill I've completed it. Could you please review it again at your earliest convenience?

HamzaIsrar12 commented 1 month ago

@volodymyr-chekyrta I'm reviewing it. 😄

volodymyr-chekyrta commented 1 month ago

Thank you guys!

volodymyr-chekyrta commented 1 month ago

Maybe we need to introduce a feature flag as well for the app-level calendar sync feature.

Just for clarification 🤓 By FC-0047 the app level calendar should replace the course level calendar.

PavloNetrebchuk commented 1 month ago

@HamzaIsrar12 Thanks for your feedback! I've added the recent changes.

openedx-webhooks commented 1 month ago

@PavloNetrebchuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.