openedx / openedx-app-android

The mobile app for Android for the Open EdX Platform.
Apache License 2.0
14 stars 19 forks source link

feat: [FC-0047] Course progress and collapsing sections #323

Closed PavloNetrebchuk closed 1 month ago

PavloNetrebchuk commented 1 month ago

https://www.figma.com/design/iZ56YMjbRMShCCDxqrqRrR/Open-edX-Mobile-App-All-Screens-v2.1?node-id=9146-62028&t=9uhsH3nbuxmXNajx-4


Light Theme Dark Theme
Screenshot 2024-05-31 at 12 47 50 Screenshot 2024-05-31 at 12 48 45

Downloading icon Not Downloaded Downloading Downloaded
Screenshot 2024-05-29 at 20 12 09 Screenshot 2024-05-29 at 20 12 21 Screenshot 2024-05-29 at 20 12 36
Screenshot 2024-05-29 at 20 15 18 Screenshot 2024-05-29 at 20 15 40 Screenshot 2024-05-29 at 20 15 51

Completion Light Theme Dark Theme
Screenshot 2024-05-29 at 20 18 27 Screenshot 2024-05-29 at 20 18 43
openedx-webhooks commented 1 month ago

Thanks for the pull request, @PavloNetrebchuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

mphilbrick211 commented 1 month ago

Hi @PavloNetrebchuk! Is this for an FC project with Axim?

PavloNetrebchuk commented 1 month ago

Hi @PavloNetrebchuk! Is this for an FC project with Axim?

Hello @mphilbrick211 Yes

volodymyr-chekyrta commented 1 month ago

Can we remove this odd ripple effect or at least limit it to the section heading where the user taps?

https://github.com/openedx/openedx-app-android/assets/127732735/4375dcb0-24c5-47cb-82bb-d778d3b5198d

volodymyr-chekyrta commented 1 month ago

@PavloNetrebchuk please update the config structure according to the https://github.com/openedx/openedx-app-android/pull/319

sdaitzman commented 1 month ago

Hi @PavloNetrebchuk, this looks great overall! A couple of design questions/feedback I wanted to check on:

  1. In light mode, sections should use the light theme shade color #F9FAFB as their background color. In the last screenshot, it looks like it might be using a darker color?
  2. In dark mode, the download icon should use the lighter dark theme accent text color #879FF5 for contrast/accessibility reasons
PavloNetrebchuk commented 1 month ago

Hello @sdaitzman, Thank you for your feedback.

  1. I double-checked the section color, and it is correct. It may appear darker in the screenshot due to compression.
  2. You are right; I used the wrong color previously. It has been corrected now.
sdaitzman commented 1 month ago

Thanks, @PavloNetrebchuk! Everything else looks great to me from a design standpoint.

openedx-webhooks commented 1 month ago

@PavloNetrebchuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

HamzaIsrar12 commented 1 month ago

Hey @PavloNetrebchuk, I pulled this branch and noticed that the download button seems a bit buggy. Could you please take a look?

https://github.com/openedx/openedx-app-android/assets/71447999/3d381757-ab24-49a5-a108-fcf87a67a416

PavloNetrebchuk commented 1 month ago

Hello, @HamzaIsrar12 You're right. I only had one downloadable item in the course when I tested it. I'll create a PR with the fix ASAP.