Closed PavloNetrebchuk closed 1 month ago
Thanks for the pull request, @PavloNetrebchuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
Hi @PavloNetrebchuk! Is this for an FC project with Axim?
Hi @PavloNetrebchuk! Is this for an FC project with Axim?
Hello @mphilbrick211 Yes
Can we remove this odd ripple effect or at least limit it to the section heading where the user taps?
https://github.com/openedx/openedx-app-android/assets/127732735/4375dcb0-24c5-47cb-82bb-d778d3b5198d
@PavloNetrebchuk please update the config structure according to the https://github.com/openedx/openedx-app-android/pull/319
Hi @PavloNetrebchuk, this looks great overall! A couple of design questions/feedback I wanted to check on:
shade
color #F9FAFB
as their background color. In the last screenshot, it looks like it might be using a darker color?dark theme accent text
color #879FF5
for contrast/accessibility reasonsHello @sdaitzman, Thank you for your feedback.
Thanks, @PavloNetrebchuk! Everything else looks great to me from a design standpoint.
@PavloNetrebchuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
Hey @PavloNetrebchuk, I pulled this branch and noticed that the download button seems a bit buggy. Could you please take a look?
https://github.com/openedx/openedx-app-android/assets/71447999/3d381757-ab24-49a5-a108-fcf87a67a416
Hello, @HamzaIsrar12 You're right. I only had one downloadable item in the course when I tested it. I'll create a PR with the fix ASAP.
https://www.figma.com/design/iZ56YMjbRMShCCDxqrqRrR/Open-edX-Mobile-App-All-Screens-v2.1?node-id=9146-62028&t=9uhsH3nbuxmXNajx-4