openedx / openedx-app-android

The mobile app for Android for the Open EdX Platform.
Apache License 2.0
14 stars 19 forks source link

fix: sourceSets dir fallback #335

Closed volodymyr-chekyrta closed 1 month ago

volodymyr-chekyrta commented 1 month ago

This PR introduces a fallback for the sourceSets directory. This fallback is aimed at fixing an issue with the Tutor build.

Config:

THEME_DIRECTORY: "openedx"
openedx-webhooks commented 1 month ago

Thanks for the pull request, @volodymyr-chekyrta! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

HamzaIsrar12 commented 1 month ago

@volodymyr-chekyrta A better solution would be to introduce a new flag with the default value openedx and base the resources on that, instead of relying on the platformName. Thoughts?

volodymyr-chekyrta commented 1 month ago

@volodymyr-chekyrta A better solution would be to introduce a new flag with the default value openedx and base the resources on that, instead of relying on the platformName. Thoughts?

@HamzaIsrar12, I was thinking about this option too. I've updated the approach to the feature flag ✅

volodymyr-chekyrta commented 1 month ago

I would prefer THEME_DIRECTORY because it covers fonts, drawables, views etc

Makes sense 👍 Updated ✅

openedx-webhooks commented 1 month ago

@volodymyr-chekyrta 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.