search

openedx / openedx-app-android

The mobile app for Android for the Open EdX Platform.
Apache License 2.0
14 stars 19 forks source link

fix: Video Subtitles on Native and Youtube Player #349

Closed HamzaIsrar12 closed 1 day ago

HamzaIsrar12 commented 2 weeks ago

The video subtitles weren't working because the handler was deleted.

omerhabib26 commented 1 week ago

No need for this PR, everything is already handled in https://github.com/openedx/openedx-app-android/pull/347

HamzaIsrar12 commented 6 days ago

@omerhabib26 The commit from this branch was mistakenly cherry-picked there, so I removed it.

omerhabib26 commented 6 days ago

@HamzaIsrar12 just a minor suggestion, Can you update the highlighted text style to SemiBold for better visibility? cc: @moiz994