openedx / openedx-app-ios

The mobile app for iOS for the Open EdX Platform.
Apache License 2.0
19 stars 14 forks source link

[iOS] Move Course menu from bottom to top #154

Closed sergeymomot closed 7 months ago

sergeymomot commented 10 months ago

Need to move Course menu from the bottom of the screen to the top of the screen. Course menu should scroll left and right. Course elements (Home-Videos-Dates etc.) should scroll left and right by swiping.

marcotuts commented 9 months ago

@sdaitzman - this is the ticket that could use design definition asap

miankhalid commented 9 months ago

@marcotuts @sdaitzman any update on the designs for this feature? cuz its currently blocking the PR review of #181

miankhalid commented 9 months ago

@marcotuts @sdaitzman btw PR #181 does include a video showing the current implementation that you can review here: https://github.com/openedx/openedx-app-ios/pull/181#issuecomment-1833336934

sdaitzman commented 9 months ago

@miankhalid thanks, working to get design updates ready to share as soon as possible. The new top navigation has some key design improvements and looks great, but there are a couple changes we're likely to request:

Here's an early mockup of these updates (pending some changes, especially below the nav, but sharing this for reference). Hopefully we can unblock the top-navigation PR. Do these changes to the navigation seem feasible?

image

image

moiz994 commented 9 months ago

Thanks, @sdaitzman ! This unblocks the dev team for now. We can do a fast follow-up to this in case there are any changes in design moving forward.

tagging @ekangedx for visibility into design updates.

touchapp commented 9 months ago

Curious if we can use that design, thoughts @ekangedx ?

ekangedx commented 9 months ago

Thanks for bringing this to my attention @moiz994 @touchapp I think we should stick to using tab nav here if possible. We met earlier this week and discussed using pills as navigation is a lesser common pattern with some known usability issues as well as unvetted usability questions.

Here are some of the unresolved concerns for using pills and why tab nav might be a better choice here:

sdaitzman commented 9 months ago

Hi @ekangedx, thank you for raising these concerns. I want to make sure we address them fully and meet the usability heuristics you mentioned. I hope we can discuss them at the mobile design weekly tomorrow, and we can share out our findings here.

I think some of the usability concerns you raised have been addressed within our design process. For example, we tested the pill design and layout we propose on all common mobile device sizes from iPhone 12 Mini to iPhone 15 Pro Max, and the pill layout affords visual continuity on that full range. Happy to share more detail on the other concerns you raised, if that would be helpful.

Editing to add: we discussed the navigation structure at the mobile design weekly meeting, and will reconvene at the next mobile design weekly on December 19 to review updated designs.