search

openedx / openedx-app-ios

The mobile app for iOS for the Open EdX Platform.
Apache License 2.0
19 stars 13 forks source link

Course bars: Download videos to device and Select download quality bars #239

Closed eyatsenkoperpetio closed 5 months ago

eyatsenkoperpetio commented 5 months ago

Add Progress Downloads View #166 The user can view the download statuses or the number of downloads in the Download Progress section.

Add notification about downloading a large video #167 Need to add notification about downloading a large video.

Bulk Download of Course Videos #168 Add the option to download all videos at once on the video tab.

Add an controller to select Quality of the downloadable video #217 User should be able to choose the quality of the downloadable video. Roughly the way it is implemented in the current application (this controller can be opened from course -> videos and from users Profile)

Add download pause/resume action after collapse/expand the app #228 Add auto pause/resume action for downloadable content after collapse and expand the app.

Add ability to open and download currently unsupported videos #229 find out the reason why these videos are not open find out how to download this content for offline mode

https://github.com/openedx/openedx-app-ios/assets/76485998/06cfb21c-edc3-49ed-88ca-62a8ea638ffe

rnr commented 5 months ago
  • Streameable and downloaded videos are not playing
  • If the internet isn't available the download to device view replaced with noWifiMessage message. The noWifiMessage should be displaced on toggling on the download switch as an error.
  • When downloading videos for a sub section, the circular progress appears with cross. It would be nice if we follow the prod app behavior and show loader without cross and on clicking the loader the download detail screen appears.
  • It would be nice to add a confirmation alert before deleting the downloaded videos because button can be clicked accidentally. On prod we are using swipe to delete which is a safe approch.
  • On the prod app, on switching off the Download to device switch, we perform the action with a delay of 4 seconds and if user turned back on the delete action is canceled
  • The download progress bar flickers both on download to device view and download progress detail view
  • The download progress bar on detail screen uses default color

Hello @saeedbashir Thank you for such a detailed review. Not all of your comments apply to the tasks in the description. Especially these:

I think we need to agree that this isn't an "All downloads work" PR - if we tried to do that in one PR, it would require tons of code and a lot of time for review-fixes-rereview-etc. This PR started with the "Add a download quality panel" task and has gotten so big. I think we need to break it down into steps. We'll convert all your comments into tickets and add them to the Epic of this ticket. Let's please focus on a first bunch of tasks in the description.

What do you think? Thank you cc @eyatsenkoperpetio @touchapp

sergeymomot commented 5 months ago

Hello @saeedbashir I created a separate ticket for these point:

  • If the internet isn’t available the download to device view replaced with noWifiMessage message. The noWifiMessage should be displaced on toggling on the download switch as an error.
  • When downloading videos for a sub section, the circular progress appears with cross. It would be nice if we follow the prod app behavior and show loader without cross and on clicking the loader the download detail screen appears.
  • The download progress bar flickers both on download to device view and download progress detail view

cc @eyatsenkoperpetio @rnr

volodymyr-chekyrta commented 5 months ago

Ready to merge