search

openedx / openedx-app-ios

The mobile app for iOS for the Open EdX Platform.
Apache License 2.0
20 stars 16 forks source link

Whats new page hidding #245

Closed rnr closed 8 months ago

rnr commented 8 months ago

PR for https://github.com/openedx/openedx-app-ios/issues/224 Added FF WHATS_NEW_IMAGE_OR_TITLE_TO_SKIP_PAGE - it can contain the image name or page title from the What's new JSON file. Pages with such image name or title will be skipped in the What's new function. To test you can use this config https://github.com/edx/edx-mobile-config/tree/anton/whatsnew or add this to shared.yaml manually like:

UI_COMPONENTS:
    WHATS_NEW_IMAGE_OR_TITLE_TO_SKIP_PAGE: 'Learning Site Switching'

The process_config.py script has also been changed, it will now try to merge dictionaries from different files (e.g. iOS.yaml and shared.yaml) if both files have the same section with children in them

saeedbashir commented 8 months ago

@rnr As discussed over the huddle, this PR isn't needed as every version will be having it's own copy of whatsnew messages and images.

rnr commented 8 months ago

Looks like this should be resolved differently. Thanks to @saeedbashir for the clarification.