search

openedx / openedx-app-ios

The mobile app for iOS for the Open EdX Platform.
Apache License 2.0
19 stars 13 forks source link

Replace WhatsNew file with Script #254

Closed rnr closed 5 months ago

rnr commented 5 months ago

PR for https://github.com/openedx/openedx-app-ios/issues/224 Page hiding is implemented as part of 'theming'

How to test

Clone https://github.com/edx/edx-mobile-config into the OpenEdX root folder and switch to the anton/openedX-theming branch.

From the OpenEdX root folder, run the script as:

python config_script/whitelabel.py --config-file=edx-mobile-config/openEdXAssets/whitelabel.yaml -v

Install on your simulator or device

The last page (Learning Site Switching) in What's New will de hidden

Also the process_config.py script has been changed, it will now try to merge dictionaries from different files (e.g. iOS.yaml and shared.yaml) if both files have the same section with children in them

touchapp commented 5 months ago

Lets merge this if it passes

shafqat-muneer commented 5 months ago

@rnr In whilelabel.yaml file, if I remove all configurations and just place whatsnew related configuration:

whatsnew:
  whatsnew_import_file_path: './edx-mobile-config/openEdXAssets/WhatsNew/whats_new.json'
  project_whatsnew_file_path: './WhatsNew/WhatsNew/Data/WhatsNew.json'

In this case, getting following errors by running command:

python3 config_script/whitelabel.py --config-file=edx-mobile-config/openEdXAssets/whitelabel.yaml -v
Screenshot 2024-01-26 at 2 40 13 PM

Suggestion: I think if any configuration is not present then it's related errors should also not come.

saeedbashir commented 5 months ago

Clone https://github.com/edx/edx-mobile-config into the OpenEdX root folder and switch to the anton/openedX-theming branch.

@rnr is it possible to merge this branch with saeed/openedX and same in the case of yyatsenko/unit_progress so that we don't need to switch config branches again and again for different features and everyone from Axinite and Touchmedia will have the same copy of data all the time.

saeedbashir commented 5 months ago

The title of the PR can be updated to Replace WhatsNew file with Script or something similar.

rnr commented 5 months ago

Clone https://github.com/edx/edx-mobile-config into the OpenEdX root folder and switch to the anton/openedX-theming branch.

@rnr is it possible to merge this branch with saeed/openedX and same in the case of yyatsenko/unit_progress so that we don't need to switch config branches again and again for different features and everyone from Axinite and Touchmedia will have the same copy of data all the time.

done

rnr commented 5 months ago

The title of the PR can be updated to Replace WhatsNew file with Script or something similar.

done