search

openedx / openedx-app-ios

The mobile app for iOS for the Open EdX Platform.
Apache License 2.0
19 stars 13 forks source link

iOS - Issues and improvements related to the Video Downloads #255

Open hassan6190 opened 5 months ago

hassan6190 commented 5 months ago

After testing the Video Downloads the following issues have been found

  1. Download all videos toggle shows the text “Download to device“ whereas the videos are not downloaded in the device after downloading (Same as Prod build)
  2. The YouTube video also shows the download icon
  3. YouTube video is downloading but unable to play offline
  4. We are unable to identify the YouTube video as there is no YouTube icon
  5. The video is not automatically played after loading the video
    • The video only plays when we tap on the play button
  6. The subtitles for the videos are not visible in the video
    • The subtitles are only visible as a description below the video
    • If a user plays the video in full screen then he/she can’t see the subtitles
  7. Playback speed is not working as the market build
    • When a user changes the video’s playback speed it doesn’t remain the same after going back and loading the same video
  8. Videos get deleted after signing off and then signing in with the same account
rnr commented 5 months ago

@hassan6190 please add info which branch do you test. We have PR in review now and I want to be sure you are testing the latest work. Thank you

hassan6190 commented 5 months ago

@rnr I was testing the iOS build (10.10.100 (24)) from TestFlight

rnr commented 3 months ago

Hello @hassan6190 Do you still facing some of these issues? Thank you

hassan6190 commented 3 months ago

Hi @rnr I am still facing most of the issues. I am testing these issues on iOS Build (10.10.100 (24)) TestFlight

rnr commented 3 months ago

Hi @hassan6190 I just uploaded 10.100.100 (35) - please re-test this with it. Thank you

rnr commented 3 months ago

@saeedbashir uploaded build 10.10.100 (35) at the same time. @hassan6190, please use his build to avoid confusion with version numbers.

rnr commented 3 months ago

@hassan6190 Do you have any updates on this with the latest build of TestFlight? Thank you

marcotuts commented 2 months ago

This seems like the last remaining issue before merging the parent epic - I also struggled to get the videos tab to load / behave as expected, once a test build that incorporates this it may be worth another acceptance review fyi @moiz994