search

openedx / openedx-app-ios

The mobile app for iOS for the Open EdX Platform.
Apache License 2.0
20 stars 16 forks source link

feat: Enrolled Web Based Programs Implementation #260

Closed saeedbashir closed 8 months ago

saeedbashir commented 8 months ago

This PR adds support for web-based enrolled programs.

[iOS] Program Progress Page

https://github.com/openedx/openedx-app-ios/assets/5606473/a3af6a5d-23af-4469-b9e7-0accf414546f

saeedbashir commented 8 months ago

@rnr Replying to your comments here as I've closed the other PR.

@saeedbashir If Discovery Config now contains both Discovery and Program config, perhaps we need to rename it to some "level up" entry. Thoughts?

I gave it a thought and also discussed it with the team. DiscoveryConfig is the more suitable name that can represent both features as 70% of programs are also discover. If you have a name on you mind please let me know.

@saeedbashir I know it's webView based content but perhaps we can add a small css injection to add some left padding?

This will make it a bit hard to maintain it, like we have to maintain it on new and old apps and it will also not fix the issue on the mobile browsers. We will create a ticket for the web team to fix it so that the problem will be fixed for all small screens.

saeedbashir commented 8 months ago

@volodymyr-chekyrta Could you please spare some time and review it thanks.

volodymyr-chekyrta commented 8 months ago

Let's merge it after the tests pass