feat: Problem with course menu position on iPad and in Landscape mode on iPhone

[forgotvas]

[iOS] Problem with course menu position on iPad and in Landscape mode on iPhone #234

During that ticket was added accessibility injection for increase font size inside webview that depends on accessibility font size. Paddings based on readability content size that will increase if user will reduce font size and will reduce if user will increase font size. Demo video

Portrait Changes

Before|After --|-- | | | | | | | | | | | | | | | | | | | | | | | | |

Landscape Changes

Before|After --|-- | | | | | | | | | | | | | | | | | | | | | | | |

[rnr]

@saeedbashir We are all just waiting for your review. Please take a look. Thank you.

[saeedbashir]

1. @forgotvas Could you please correct the alignment of Or sign in with and Or register with on sign-in and register screens?
2. I'm not sure how the is working. Although it's look good, but there is enough content in case of Privacy Policy, etc and it left space empty space on both sides. The same is the case with HTML based blocks. But the discover and program web views uses full available space.

[saeedbashir]

Not sure, but we might have two course cards in one row in case of iPad, just like we have it on production app.

[forgotvas]

Not sure, but we might have two course cards in one row in case of iPad, just like we have it on production app.

@rnr ^^^

[forgotvas]

1. @forgotvas Could you please correct the alignment of Or sign in with and Or register with on sign-in and register screens?
2. I'm not sure how the is working. Although it's look good, but there is enough content in case of Privacy Policy, etc and it left space empty space on both sides. The same is the case with HTML based blocks. But the discover and program web views uses full available space.

Hi @saeedbashir,

1. Do you want it to be centered?
2. In iOS 9 apple introduced readabilityContentGuide https://developer.apple.com/documentation/uikit/uiview/1622644-readablecontentguide#discussion and dynamic type. They made that release to make user easily be read without forcing users to move their head to track the lines. Some old tutorial. In guidelines apple wrote:

Modify the built-in text styles if necessary. System APIs define font adjustments — called symbolic traits — that let you modify some aspects of a text style. For example, the bold trait adds weight to text, letting you create another level of hierarchy. You can also use symbolic traits to adjust leading if you need to improve readability or conserve space. For example, when you display text in wide columns or long passages, more space between lines (loose leading) can make it easier for people to keep their place while moving from one line to the next. Conversely, if you need to display multiple lines of text in an area where height is constrained — for example, in a list row — decreasing the space between lines (tight leading) can help the text fit well. If you need to display three or more lines of text, avoid tight leading even in areas where height is limited. For developer guidance, see leading(_:).

We didn't touch discovery and programs tabs because there not a content type it's more like browser so it should be on full screen.

[saeedbashir]

1. Do you want it to be centered?

How about aligning it to other content like textfields?

[rnr]

Not sure, but we might have two course cards in one row in case of iPad, just like we have it on production app.

@rnr ^^^

@forgotvas I think we could try this approach. Thank you

[forgotvas]

1. Do you want it to be centered?

How about aligning it to other content like textfields?

@saeedbashir, done:

[forgotvas]

Not sure, but we might have two course cards in one row in case of iPad, just like we have it on production app.

@rnr ^^^

@forgotvas I think we could try this approach. Thank you

@sergeymomot please create ticket for that

[volodymyr-chekyrta]

@forgotvas please resolve the conflicts

[forgotvas]

@volodymyr-chekyrta, done