openedx / openedx-app-ios

The mobile app for iOS for the Open EdX Platform.
Apache License 2.0
19 stars 13 forks source link

fix: remove entitlement files editing for associated domains from config script #307

Closed saeedbashir closed 4 months ago

saeedbashir commented 4 months ago

We've added the capability to modify entitlements files on compile time for branch SDK to modify the associated domains depending on the values of the config under the scope of https://github.com/openedx/openedx-app-ios/pull/283.

But modifying the entitlements file on compile time results in very odd issues like not maintaining user sessions across runs, not letting the user login sometimes, etc.

I've removed the entitlements modification part from the config process script. We will review it post MVP and will see whether we will be able to modify entitlements with the whitelabel or not.

volodymyr-chekyrta commented 4 months ago

Let's create a ticket for future research and enhancements