search

openedx / openedx-app-ios

The mobile app for iOS for the Open EdX Platform.
Apache License 2.0
19 stars 13 forks source link

feat: use custom font and colors across the app where were missing #311

Closed saeedbashir closed 3 months ago

saeedbashir commented 4 months ago

At a number of places, the default font was being used for so many elements, and the same was the case for colors. At a number of place, like the .red color was used at a number of places instead of the custom Alert color.

This PR fixes the issue and enhances the app theme capability by applying the app defined colors and app defined custom fonts across the app.

Note:

  1. This PR will not impact the openedX default theme. The colors scheme will remain the same.
  2. The default font is still being used for picker (discussion filters, discussion sort), as there isn't a straight-forward way to use custom fonts for picker items. Will look into it later.
rnr commented 4 months ago

I also see some font size changes for openEdX on the login page. Please confirm if this is acceptable.

Screenshot 2024-03-06 at 14 52 11
saeedbashir commented 4 months ago

@rnr feedback addressed and I've corrected the size of sign-in screen elements

rnr commented 3 months ago

looks good to me please fix one issue for edx dark mode Screenshot 2024-03-06 at 13 39 26

@saeedbashir please confirm we don't need border for Cancel button here in dark mode

saeedbashir commented 3 months ago

looks good to me please fix one issue for edx dark mode Screenshot 2024-03-06 at 13 39 26

@saeedbashir please confirm we don't need border for Cancel button here in dark mode

The screenshot is not accessible. Anyhow, this is just a developer copy of the design so that the app looks presentable in dark mode. We might end up changing the whole color scheme after the design team reviews it.