openedx / openedx-app-ios

The mobile app for iOS for the Open EdX Platform.
Apache License 2.0
19 stars 13 forks source link

Fix for the alignment of the "Back to profile" button #345

Closed rnr closed 3 months ago

rnr commented 3 months ago

Fix for 325 Issue As @sdaitzman suggested, the "Back to Profile" button uses the basic button style. The "Delete Account" button uses the red error/danger colour to highlight which action is destructive. Also, StyledButton View can now have an icon image. The icon can be placed to the left or right of the button title text.

Inactive delete button:

Light Dark
1e067826-15dc-4c12-b5e3-64a63dac19d2 f590ec79-f07c-414c-948f-45548e4095e8

Active delete button:

Light Dark
a49d8ae4-50da-48fb-908b-a99fbc678b73 2b8ee67d-ee7c-4c0e-b11f-e42f347a49cc
saeedbashir commented 3 months ago

@rnr Please switch the button styles i.e the Yes, delete account will be a filled button (primary button style) and Back to profile will be with a clear bg.

Oh, it was already discussed here https://github.com/openedx/openedx-app-ios/issues/315#issuecomment-1989036359