openedx / openedx-app-ios

The mobile app for iOS for the Open EdX Platform.
Apache License 2.0
19 stars 13 forks source link

feat: Dates Tab integration with Calendar #347

Closed shafqat-muneer closed 3 months ago

shafqat-muneer commented 3 months ago

Jira Tickets:

Github Issues:

Light Mode Dark Mode
Simulator Screenshot - iPhone 15 - 2024-03-15 at 12 36 45 Simulator Screenshot - iPhone 15 - 2024-03-15 at 12 37 36
Simulator Screenshot - iPhone 15 - 2024-03-15 at 12 36 51 Simulator Screenshot - iPhone 15 - 2024-03-15 at 12 37 47
Simulator Screenshot - iPhone 15 - 2024-03-15 at 12 36 55 Simulator Screenshot - iPhone 15 - 2024-03-15 at 12 37 52
Simulator Screenshot - iPhone 15 - 2024-03-15 at 12 37 11 Simulator Screenshot - iPhone 15 - 2024-03-15 at 12 38 09
Simulator Screenshot - iPhone 15 - 2024-03-15 at 12 37 18 Simulator Screenshot - iPhone 15 - 2024-03-15 at 12 38 15
Simulator Screenshot - iPhone 15 - 2024-03-15 at 12 37 21 Simulator Screenshot - iPhone 15 - 2024-03-15 at 12 38 19
Simulator Screenshot - iPhone 15 - 2024-03-15 at 12 39 38 Simulator Screenshot - iPhone 15 - 2024-03-15 at 12 40 13
Simulator Screenshot - iPhone 15 - 2024-03-15 at 12 41 29 Simulator Screenshot - iPhone 15 - 2024-03-15 at 12 40 30
Simulator Screenshot - iPhone 15 - 2024-03-18 at 01 06 21 Simulator Screenshot - iPhone 15 - 2024-03-18 at 01 06 54
Simulator Screenshot - iPhone 15 - 2024-03-18 at 01 06 25 Simulator Screenshot - iPhone 15 - 2024-03-18 at 01 06 58
Simulator Screenshot - iPhone 15 - 2024-03-18 at 01 06 31 Simulator Screenshot - iPhone 15 - 2024-03-18 at 01 07 32

Demos

Light Mode: Sync and un-sync events in calendar application:

https://github.com/openedx/openedx-app-ios/assets/11990137/6ede28c0-ee35-4ada-9a36-0b68ec78e809

Light Mode: Update out dated calendar:

https://github.com/openedx/openedx-app-ios/assets/11990137/62096372-c2f7-468c-83fd-04c4af5904a3

Light Mode: Deep Linking:

https://github.com/openedx/openedx-app-ios/assets/11990137/3158a1f9-08d9-45d4-af6c-0ff2c20cb1eb

Dark Mode: Sync and un-sync events in calendar application:

https://github.com/openedx/openedx-app-ios/assets/11990137/ee88045d-6afa-483e-ac85-b5c43be4edbb

Dark Mode: Update out dated calendar:

https://github.com/openedx/openedx-app-ios/assets/11990137/fea2905e-4b98-455a-bb03-0c4f43c5204b

volodymyr-chekyrta commented 3 months ago

Hey @shafqat-muneer, thanks, looks great! 🚀 Do you know why the deep link from the calendar app didn't take the user to the specific course page? I thought it would work after @eyatsenkoperpetio introduced https://github.com/openedx/openedx-app-ios/pull/329 Do we need to develop anything else to make it work like that?

https://github.com/openedx/openedx-app-ios/assets/11990137/3158a1f9-08d9-45d4-af6c-0ff2c20cb1eb

shafqat-muneer commented 3 months ago

Hey @shafqat-muneer, thanks, looks great! 🚀 Do you know why the deep link from the calendar app didn't take the user to the specific course page? I thought it would work after @eyatsenkoperpetio introduced #329 Do we need to develop anything else to make it work like that?

RPReplay_Final1710750802.mp4

Hi @volodymyr-chekyrta, thanks for the review. I've just finished implementing the generation of deep link URLs for the calendar in this pull request. That's why it hasn't been included in #329. I'll proceed to open another pull request to direct the user to the specific course page.

volodymyr-chekyrta commented 3 months ago

Hey @shafqat-muneer, thanks, looks great! 🚀 Do you know why the deep link from the calendar app didn't take the user to the specific course page? I thought it would work after @eyatsenkoperpetio introduced #329 Do we need to develop anything else to make it work like that? RPReplay_Final1710750802.mp4

Hi @volodymyr-chekyrta, thanks for the review. I've just finished implementing the generation of deep link URLs for the calendar in this pull request. That's why it hasn't been included in #329. I'll proceed to open another pull request to direct the user to the specific course page.

Makes sense to me, thank you! 👍

shafqat-muneer commented 3 months ago

@saeedbashir I have made the recommended adjustments. Kindly review them.

shafqat-muneer commented 3 months ago

@saeedbashir I have addressed requested changes.

@volodymyr-chekyrta Please also review this pull request. Thank you.