Closed shafqat-muneer closed 3 months ago
Hey @shafqat-muneer, thanks, looks great! 🚀 Do you know why the deep link from the calendar app didn't take the user to the specific course page? I thought it would work after @eyatsenkoperpetio introduced https://github.com/openedx/openedx-app-ios/pull/329 Do we need to develop anything else to make it work like that?
https://github.com/openedx/openedx-app-ios/assets/11990137/3158a1f9-08d9-45d4-af6c-0ff2c20cb1eb
Hey @shafqat-muneer, thanks, looks great! 🚀 Do you know why the deep link from the calendar app didn't take the user to the specific course page? I thought it would work after @eyatsenkoperpetio introduced #329 Do we need to develop anything else to make it work like that?
RPReplay_Final1710750802.mp4
Hi @volodymyr-chekyrta, thanks for the review. I've just finished implementing the generation of deep link URLs for the calendar in this pull request. That's why it hasn't been included in #329. I'll proceed to open another pull request to direct the user to the specific course page.
Hey @shafqat-muneer, thanks, looks great! 🚀 Do you know why the deep link from the calendar app didn't take the user to the specific course page? I thought it would work after @eyatsenkoperpetio introduced #329 Do we need to develop anything else to make it work like that? RPReplay_Final1710750802.mp4
Hi @volodymyr-chekyrta, thanks for the review. I've just finished implementing the generation of deep link URLs for the calendar in this pull request. That's why it hasn't been included in #329. I'll proceed to open another pull request to direct the user to the specific course page.
Makes sense to me, thank you! 👍
@saeedbashir I have made the recommended adjustments. Kindly review them.
@saeedbashir I have addressed requested changes.
@volodymyr-chekyrta Please also review this pull request. Thank you.
Jira Tickets:
Github Issues:
160
271
Demos
Light Mode: Sync and un-sync events in calendar application:
https://github.com/openedx/openedx-app-ios/assets/11990137/6ede28c0-ee35-4ada-9a36-0b68ec78e809
Light Mode: Update out dated calendar:
https://github.com/openedx/openedx-app-ios/assets/11990137/62096372-c2f7-468c-83fd-04c4af5904a3
Light Mode: Deep Linking:
https://github.com/openedx/openedx-app-ios/assets/11990137/3158a1f9-08d9-45d4-af6c-0ff2c20cb1eb
Dark Mode: Sync and un-sync events in calendar application:
https://github.com/openedx/openedx-app-ios/assets/11990137/ee88045d-6afa-483e-ac85-b5c43be4edbb
Dark Mode: Update out dated calendar:
https://github.com/openedx/openedx-app-ios/assets/11990137/fea2905e-4b98-455a-bb03-0c4f43c5204b