openedx / openedx-app-ios

The mobile app for iOS for the Open EdX Platform.
Apache License 2.0
19 stars 13 forks source link

feat: Text and icons adjustment project #364

Closed IvanStepanok closed 3 months ago

IvanStepanok commented 3 months ago

Figma design changes: https://www.figma.com/file/iZ56YMjbRMShCCDxqrqRrR/Open-edX-Mobile-App-All-Screens-v2.1?type=design&node-id=9980-2&mode=design&t=ThvK5qvjJxh91mw2-0

Changed icon Simulator Screenshot - iPhone 15 Pro Max - 2024-03-20 at 15 28 48

Empty state’s title has been removed Simulator Screenshot - iPhone 15 Pro Max - 2024-03-20 at 15 27 30

Changed subtitle Simulator Screenshot - iPhone 15 Pro Max - 2024-03-20 at 15 22 32

Internet warning text has been changed Simulator Screenshot - iPhone 15 Pro Max - 2024-03-20 at 15 22 11

Changed subtitle. “Handouts” changed to “More” Simulator Screenshot - iPhone 15 Pro Max - 2024-03-20 at 15 21 44

Changed title and icon Simulator Screenshot - iPhone 15 Pro Max - 2024-03-20 at 15 21 17

Changed title and subtitle Simulator Screenshot - iPhone 15 Pro Max - 2024-03-20 at 15 17 53

Changed subtitle Simulator Screenshot - iPhone 15 Pro Max - 2024-03-20 at 15 15 58

The title of the message has been removed. Simulator Screenshot - iPhone 15 Pro Max - 2024-03-20 at 15 15 36

Changed icon, title, and subtitle Simulator Screenshot - iPhone 15 Pro Max - 2024-03-20 at 15 15 27

openedx-webhooks commented 3 months ago

Thanks for the pull request, @IvanStepanok! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

volodymyr-chekyrta commented 3 months ago

@IvanStepanok, we need to check that we are using the text "Log out" and not "Logout" on the popup.

image

cc @sdaitzman

volodymyr-chekyrta commented 3 months ago

@IvanStepanok correct text Subtitle + button

image
IvanStepanok commented 3 months ago

Ready

Screenshot 2024-03-25 at 19 45 43
IvanStepanok commented 3 months ago

Thanks guys🙌

openedx-webhooks commented 3 months ago

@IvanStepanok 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.