search

openedx / openedx-app-ios

The mobile app for iOS for the Open EdX Platform.
Apache License 2.0
19 stars 13 forks source link

feat: Calendar deep link to course component #381

Closed shafqat-muneer closed 2 months ago

shafqat-muneer commented 3 months ago

LEARNER-9888: Navigate to a particular course component upon tapping the link from the native calendar application synced with the calendar for that specific course.

Demo:

https://github.com/openedx/openedx-app-ios/assets/11990137/d83276a7-98a3-4bb9-80e1-d6e0e0cd688e

eyatsenkoperpetio commented 3 months ago

@shafqat-muneer can you open full flow to this component?

for example, open from push: https://github.com/openedx/openedx-app-ios/assets/76485998/f237be3d-b671-4cfa-83c1-d8c9b461160d

shafqat-muneer commented 3 months ago

@shafqat-muneer can you open full flow to this component?

for example, open from push: https://github.com/openedx/openedx-app-ios/assets/76485998/f237be3d-b671-4cfa-83c1-d8c9b461160d

@eyatsenkoperpetio This flow will execute from native calendar link which is demoed in this video. Do you have any scenario in which it can execute through push notification?

volodymyr-chekyrta commented 3 months ago

@shafqat-muneer can you open full flow to this component? for example, open from push: https://github.com/openedx/openedx-app-ios/assets/76485998/f237be3d-b671-4cfa-83c1-d8c9b461160d

@eyatsenkoperpetio This flow will execute from native calendar link which is demoed in this video. Do you have any scenario in which it can execute through push notification?

@shafqat-muneer, I believe @eyatsenkoperpetio didn't mean to open that from a push notification, we probably need to open the full user path MainView -> Course -> Course Sequential (Optional) -> xBlock instead of MainView -> xBlock as @eyatsenkoperpetio demonstrated on video for deep links from pushes.

I think this is the right way too. If we give users the full path, they can just hit the back button to return to the course and keep learning with the next or previous section.

shafqat-muneer commented 3 months ago

@volodymyr-chekyrta It appears I misunderstood. Thank you for providing clarification. @eyatsenkoperpetio I'll adjust accordingly based on that.

shafqat-muneer commented 2 months ago

@eyatsenkoperpetio I have completed the changes and have also included an updated demo video in the description of the PR. Please review it.