openedx / openedx-app-ios

The mobile app for iOS for the Open EdX Platform.
Apache License 2.0
19 stars 13 forks source link

feat: [FC-0047] move the certificate view from the banner to the message section #387

Closed IvanStepanok closed 2 months ago

IvanStepanok commented 2 months ago

This PR is a part of the big redesign project: https://www.figma.com/file/iZ56YMjbRMShCCDxqrqRrR/Open-edX-Mobile-App-All-Screens-v2.1?type=design&node-id=9067-117961&mode=design&t=BuD1FjzhniDjciHX-0

simulator_screenshot_2A6FAA88-F9FF-43BF-9A3C-C56942E41244 Simulator Screenshot - iPhone 15 Pro Max - 2024-04-04 at 16 03 10

on iPad Simulator Screenshot - iPad (10th generation) - 2024-04-04 at 16 04 31

openedx-webhooks commented 2 months ago

Thanks for the pull request, @IvanStepanok! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

volodymyr-chekyrta commented 2 months ago

Ready for product review

saeedbashir commented 2 months ago

https://www.figma.com/file/iZ56YMjbRMShCCDxqrqRrR/Open-edX-Mobile-App-All-Screens-v2.1?type=design&mode=design

@IvanStepanok Is this the right link to see the updated screens. I'm not able to locate the highlighted changes in this file.

IvanStepanok commented 2 months ago

https://www.figma.com/file/iZ56YMjbRMShCCDxqrqRrR/Open-edX-Mobile-App-All-Screens-v2.1?type=design&mode=design

@IvanStepanok Is this the right link to see the updated screens. I'm not able to locate the highlighted changes in this file.

Thanks for flagging it for me, the link is updated.

Here is the actual one: https://www.figma.com/file/iZ56YMjbRMShCCDxqrqRrR/Open-edX-Mobile-App-All-Screens-v2.1?type=design&node-id=9067-117961&mode=design&t=BuD1FjzhniDjciHX-0

IvanStepanok commented 2 months ago

The feedback has been addressed, and the PR is ready for another pass.

volodymyr-chekyrta commented 2 months ago

@saeedbashir, would you like to provide a review, or should we just merge the PR?

openedx-webhooks commented 2 months ago

@IvanStepanok 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.