openedx / openedx-app-ios

The mobile app for iOS for the Open EdX Platform.
Apache License 2.0
20 stars 15 forks source link

fix: RTL arrowLeft in core assets #440

Closed RawanMatar89 closed 4 months ago

RawanMatar89 commented 4 months ago

New contributor

I'm Rawan Matar, from ZeitLabs. I start working on supporting RTL in OpenEdx iOS app, and this is the first change in my plan.

Description

changed the direction attribute of the "arrowLeft" image in Core/Assets.

Screenshots

Before After
IMG_3090 IMG_3087
openedx-webhooks commented 4 months ago

Thanks for the pull request, @RawanMatar89! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

openedx-webhooks commented 4 months ago

@RawanMatar89 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

OmarIthawi commented 4 months ago

Thanks @RawanMatar89 and @volodymyr-chekyrta!! We're looking forward for more fixes in regards to RTL and SAML.