openedx / openedx-app-ios

The mobile app for iOS for the Open EdX Platform.
Apache License 2.0
19 stars 13 forks source link

feat: Program Screen Error Handling #448

Closed shafqat-muneer closed 2 days ago

shafqat-muneer commented 3 weeks ago

LEARNER-9992: feat: Program Screen Error Handling

Light Mode Dark Mode
Simulator Screenshot - iPhone 15 - 2024-06-03 at 10 53 51 Simulator Screenshot - iPhone 15 - 2024-06-03 at 10 53 48
shafqat-muneer commented 3 weeks ago

@saeedbashir Feedback addressed. Ready for another round of review 🎉

rnr commented 3 weeks ago

@moiz994 do we need this yellow line on Programs and Discover screens?

rnr commented 3 weeks ago

@shafqat-muneer When the connection is restored and we get the data on the Program screen (for example) and then go to the Discover screen, there we see a different error ("something went wrong" instead of "no connection"). Is this expected?

https://github.com/openedx/openedx-app-ios/assets/37253/d848e18a-5103-4af2-8c64-7724f40c9d65

shafqat-muneer commented 2 weeks ago

@moiz994 do we need this yellow line on Programs and Discover screens?

It appears to be redundant after implementation of full screen error. Just removed it from Programs and Discovery screens.

shafqat-muneer commented 1 week ago

@shafqat-muneer When the connection is restored and we get the data on the Program screen (for example) and then go to the Discover screen, there we see a different error ("something went wrong" instead of "no connection"). Is this expected?

RPReplay_Final1717765154.MOV

@rnr It's fixed.

shafqat-muneer commented 1 week ago

@rnr @saeedbashir PR is prepared for another round of review. 🎉

shafqat-muneer commented 1 week ago

@volodymyr-chekyrta This change is awaiting your review before it can be merged. Thanks

shafqat-muneer commented 3 days ago

@volodymyr-chekyrta Incorporated the suggestions. Ready for another review. 🎉