Closed shafqat-muneer closed 2 days ago
@saeedbashir Feedback addressed. Ready for another round of review 🎉
@moiz994 do we need this yellow line on Programs and Discover screens?
@shafqat-muneer When the connection is restored and we get the data on the Program screen (for example) and then go to the Discover screen, there we see a different error ("something went wrong" instead of "no connection"). Is this expected?
https://github.com/openedx/openedx-app-ios/assets/37253/d848e18a-5103-4af2-8c64-7724f40c9d65
@moiz994 do we need this yellow line on Programs and Discover screens?
![]()
It appears to be redundant after implementation of full screen error. Just removed it from Programs and Discovery screens.
@shafqat-muneer When the connection is restored and we get the data on the Program screen (for example) and then go to the Discover screen, there we see a different error ("something went wrong" instead of "no connection"). Is this expected?
RPReplay_Final1717765154.MOV
@rnr It's fixed.
@rnr @saeedbashir PR is prepared for another round of review. 🎉
@volodymyr-chekyrta This change is awaiting your review before it can be merged. Thanks
@volodymyr-chekyrta Incorporated the suggestions. Ready for another review. 🎉
LEARNER-9992: feat: Program Screen Error Handling