openedx / openedx-aspects

Aspects - Analytics for Open edX
Apache License 2.0
6 stars 7 forks source link

Add a course-level tag filter to the course comparison dashboard #248

Closed crathbun428 closed 1 week ago

crathbun428 commented 1 month ago

User Story As a course delivery team member, I want to be able to compare only courses that have specified course-level tag(s), so that I can compare courses that share something in common (subject matter, competency, etc).

Acceptance Criteria Given I have access to the Course Comparison dashboard When I view the Course Comparison dashboard Then I see that I am able to filter the courses or course runs by Course-level tag(s) And I am able to search for and select one or more values when applying the filter

And when I apply the filter, I see the course comparison dashboard update to filter and display results including only courses or course runs that match the applied filter (see note for examples and details about course tags).

Notes

  1. If a user selects the Microbiology tag to apply it to a course and the taxonomy used for that instance has a hierarchy in place (example: Biology/Microbiology), both the Biology and Microbiology tags will be applied.
  2. If a user selects multiple course tags (for example 2 course tags) when creating a course tag filter, the results show any result that has tag value 1 OR tag value 2.
  3. If a user wants to compare all courses with the Microbiology tag, they should be comparing all courses with the Microbiology tag regardless of any other tags that may be applied to those courses (for example: courses that are being analyzed may have just Biology/Microbiology applied, some may have the Biology/Microbiology and Biology/Microbiology/Microbiomes tags applied) and that’s OK, both should appear in the results for this filter.
Ian2012 commented 1 month ago

The following PRs are in progress for this work:

saraburns1 commented 3 weeks ago

Image

Ian2012 commented 3 weeks ago

@saraburns1 Can you constrain the tags column to at most 32~46 chars? If Superset tables handle that ok, then no problem

saraburns1 commented 3 weeks ago

Hmm from #249 And when there are more than N characters to be shown, we truncate this list (but allow the user some way of viewing the whole list (maybe on hover or clicking to expand/collapse).

I don't know of a way to do this, do you @Ian2012 ? I could truncate it within the sql but there wouldn't be an option to expand it.

Ian2012 commented 3 weeks ago

We are use to truncate those values with SQL, I didn't knew superset allow it to truncate it too. If Superset UI doesn't get unusable on large values I guess we can keep it as you have it right now

saraburns1 commented 3 weeks ago

Going to try it with a scroll bar at the bottom and see what the feedback is

image