openedx-webhooks
commented
1 year ago Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
- supporting documentation
- Open edX discussion forum threads
- timeline information ("this must be merged by XX date", and why that is)
- partner information ("this is a course on edx.org")
- any other information that can help Product understand the context for the PR
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
OmarIthawi
Description
git add remote --fetch originis very slow for any medium to large repository. With this fix, the performance is hugely improved by fetching only after sparse-checkout rules are set, therefore making checkout almost instant.Additionally, the
gitsteps are simplified into fewer steps.Testing
edx-platform:conf/localedirectoryTest results
The
new_implementation is waaaay faster!Performance testing code
```shell new_clone_ios() { cd /tmp rm -rf /tmp/atlas-repo mkdir -p /tmp/atlas-repo cd /tmp/atlas-repo git clone --filter=blob:none --no-checkout --depth=1 --branch=master "https://github.com/openedx/edx-app-ios.git" atlas-repo cd atlas-repo git sparse-checkout set '!*' git sparse-checkout add 'Source/**' git checkout HEAD tree } old_clone_ios() { cd /tmp rm -rf /tmp/atlas-repo mkdir -p /tmp/atlas-repo cd /tmp/atlas-repo git init -b master git remote add -f origin "https://github.com/openedx/edx-app-ios.git" git sparse-checkout set '!*' git sparse-checkout add 'Source/**' git pull origin master tree } new_clone_edx_platform() { cd /tmp rm -rf /tmp/atlas-repo mkdir -p /tmp/atlas-repo cd /tmp/atlas-repo git clone --filter=blob:none --no-checkout --depth=1 --branch=master "https://github.com/openedx/edx-platform.git" atlas-repo cd atlas-repo git sparse-checkout set '!*' git sparse-checkout add 'conf/locale/ar**' git checkout HEAD tree } old_clone_edx_platform() { cd /tmp rm -rf /tmp/atlas-repo mkdir -p /tmp/atlas-repo cd /tmp/atlas-repo git init -b master git remote add -f origin "https://github.com/openedx/edx-platform.git" git sparse-checkout set '!*' git sparse-checkout add 'conf/locale/ar**' git pull origin master tree } ################## time new_clone_ios # real 0m1.147s # user 0m0.064s # sys 0m0.016s ################## time old_clone_ios # real 1m57.448s # user 0m35.059s # sys 0m9.742s ################### time new_clone_edx_platform # real 0m2.600s # user 0m0.237s # sys 0m0.079s ################## time old_clone_edx_platform # real infinity! # user infinity! # sys infinity! ```
References
This pull request is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
Check the links above for full information about the overall project.
Internalization is being rearchitected in Open edX Python, XBlock, Micro-frontend, and other projects. There are a number of immediately visible changes:
.json,.poor.mofiles will be committed into the repos.make extract_translationsin all repositoriesBreaking Changes
One of the primary goals of the project is to avoid breaking changes. If you noticed any suspicious code, please raise your concern. But before that, please know the strategy we're following to avoid breaking changes.