openedx / openedx-atlas

An Open edX CLI tool for moving translation files from openedx-translations
GNU Affero General Public License v3.0
3 stars 7 forks source link

fix: support Apple Git #54

Closed OmarIthawi closed 3 months ago

OmarIthawi commented 3 months ago

Bug fix

Ensure atlas reads git --version correctly when the output is

$ git --version  # On Mac
git version 2.39.3 (Apple Git-146)

The (Apple Git-146) is confusing Atlas version check.

Beause it was designed with more standard git output in mind:

$ git --version  # On Linux, with the GitHub CLI
git version 2.34.1
hub version 2.14.2

Related issues

Test locally

cd ~/bin/
curl -L https://github.com/Zeit-Labs/openedx-atlas/raw/apple_git/atlas -o atlas
chmod +x atlas
atlas --version

Slack thread

openedx-webhooks commented 3 months ago

Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

OmarIthawi commented 3 months ago

@shadinaif @brian-smith-tcril would you mind give this a quick review?

Volo confirmed it works. Slack 🎉 is unbeatable:

image

openedx-webhooks commented 3 months ago

@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

github-actions[bot] commented 3 months ago

:tada: This PR is included in version 0.6.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: