search

openedx / openedx-demo-course

A demonstration course that can be imported into an Open edX instance
GNU Affero General Public License v3.0
44 stars 68 forks source link

alt attribute is unnecessary here #4

Closed davestgermain closed 10 years ago

davestgermain commented 10 years ago

LMS-1702

davestgermain commented 10 years ago

@talbs

nedbat commented 10 years ago

Why is it unnecessary, and why not remove the attribute altogether?

davestgermain commented 10 years ago

see LMS-1702 'Its alt attribute should be changed to have a null value of alt=""'

nedbat commented 10 years ago

OK, if it says that, then that's what you've done. :+1:

talbs commented 10 years ago

@nedbat, while its better form to move as many visual/decorative images (e.g. icons, backgrounds, etc.) into the CSS rendering layer as possible, we have some older front end work on the LMS that use img elements instead. My understanding is that if we remove the alt attribute from the image, the assistive tech will "announce" to the user that an image is there, thus causing confusion. By having a blank alt attribute, most assistive tech has been developed over the years to translate that to the image in the DOM has no semantic meaning, so don't even make the user aware of it.

Hope that helps. Happy to chat more about the details.

talbs commented 10 years ago

@davestgermain, this very specific fix looks good.

:thumbsup: