openedx / openedx-demo-course

A demonstration course that can be imported into an Open edX instance
GNU Affero General Public License v3.0
44 stars 68 forks source link

refactor: add enrollment start #43

Closed DmytroAlipov closed 1 year ago

DmytroAlipov commented 1 year ago

This is a backport from the master branch Set the enrollment start date to the same value as the course start date.

This change is needed because in https://github.com/openedx/edx-platform/pull/30954 default enrollment start was added to fix the course listing for an anonymous user on the index page.

Using the demo course with an empty enrollment date for import you'll get the course with the default enrollment date equal to the default course start (1 Jan 2030 for now). This will cause the deployment error when trying to enroll audit and verified users in the demo course.

openedx-webhooks commented 1 year ago

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

itsjeyd commented 1 year ago

@DmytroAlipov Thank you for your contribution!

We'll get tests enabled for you next. CC @e0d

e0d commented 1 year ago

@itsjeyd :green_circle:

dyudyunov commented 1 year ago

@connorhaugh could you take a look, please?

it is a backport from master

itsjeyd commented 1 year ago

@connorhaugh could you take a look, please?

it is a backport from master

CC @jristau1984 @teaching-and-learning, this PR is ready for review and should be quick to merge.

itsjeyd commented 1 year ago

Thanks @connorhaugh! I'm marking this as ready for merge. Could you please hit the button when you get a minute?

itsjeyd commented 1 year ago

@connorhaugh Friendly ping about merging this PR ⬆️.

openedx-webhooks commented 1 year ago

@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.