Closed kdmccormick closed 9 months ago
@sarina One last PR for you! With this one merged and the linked Tutor PR merged, we'll be fully prepped to switch over to the new demo course for Redwood.
This looks good, before I give thumbs-up I want to do a quick test of the tar.gz into my personal instance, which I'll do now
Edit: I'm getting errors; I'll work with John to resolve them this week.
This should be updated with the changes made in https://github.com/openedx/openedx-demo-course-new/pull/4 - once that's done we can go ahead and merge.
@sarina I pushed two commits, ready for your review:
I just need to address Régis's comments over on the Tutor PR, and then I think we're all set!
Hey @kdmccormick - we merged in one more change to https://github.com/openedx/openedx-demo-course-new - it'd be good to get this updated & merged, so we can close down the openedx-demo-course-new repo and churn on this PR. Let me know the best way to proceed - should we merge this and port the changes from the last PR in a separate PR?
@sarina I was holding off on merging this because it'll break importdemocourse
in Tutor Nightly unless the Tutor PR is merged first. The drift between this and openedx-demo-course-new isn't good, though, so I'm going to merge this now and the Tutor fix will be a fast follow.
This subsumes the openedx-demo-course-new into this repo, and removes the entirety of the old demo course. We will archive openedx-demo-course-new after merging this PR.
Notes for reviewers:
main
back tomaster
.Operator Impact
On its own, this PR will break the
tutor local do importdemocourse
command in Tutor Nightly. Merging this update to Tutor Nightly will fix the command again. With that PR merged:tutor local do importdemocourse
tutor local do importdemocourse demo-course/course --version master && tutor local do importdemolibraries --version master
tutor local do importdemocourse --version open-release/quince.1
tutor local do importdemocourse && tutor local do importdemolibraries