openedx / openedx-events

Open edX events from the Hooks Extensions Framework
Apache License 2.0
11 stars 21 forks source link

feat: add new learning events for course grades and badges #303

Closed kyrylo-kh closed 5 months ago

kyrylo-kh commented 9 months ago

Description:

This is a prerequisite work for the new Badges with Credly integration feature.

Changes

ISSUE: https://github.com/openedx/platform-roadmap/issues/280

Dependencies: this PR itself is a blocker for 2 PRs (LMS, Credentials) which are work in progress.

Merge deadline: ASAP when possible.

Installation instructions: nothing special.

Testing instructions: noting special.

Reviewers:

Merge checklist:

Post merge:

Author concerns:

This PR is a blocker for further LMS/Credentials contribution, since both services depend on the future openedx-events version that includes these signals/data.

openedx-webhooks commented 9 months ago

Thanks for the pull request, @kyrylo-kh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

mphilbrick211 commented 9 months ago

Hi @kyrylo-kh! Thanks for this contribution. It looks like you're contributing on behalf of Raccoon Gang. In order to get you added to Raccoon Gang's entity CLA agreement, please have your manager reach out to oscm@axim.org. Thank you!

wowkalucky commented 9 months ago

Context: Credentials Badges (+Credly integration).

This is a WIP PR to make possible early feedback. We have started from the bare minimum, but the details are still a matter of shaping.

wowkalucky commented 6 months ago

@kyrylo-kh pls update the description as well.

mariajgrimaldi commented 6 months ago

Thank you for the contribution! Could you remove the --index-url http://edx.devstack.devpi:3141/root/pypi/+simple/ so we can run the workflows? Thanks!

wowkalucky commented 6 months ago

@mariajgrimaldi requirements are clean now.

wowkalucky commented 6 months ago

@mariajgrimaldi For some reason documentation CI cannot find the latest alabaster==0.7.16. Should we bother with it?

mariajgrimaldi commented 6 months ago

@wowkalucky: I'll be looking into it. Thank you!

mariajgrimaldi commented 6 months ago

Do you folks have a draft PR in the service from where these events will be sent?

wowkalucky commented 6 months ago

@mariajgrimaldi here related Platform draft PR.

wowkalucky commented 6 months ago

I like the suggestion of refactoring the status property with constants to is_passing = <bool> as a more explicit option.

GlugovGrGlib commented 5 months ago

@mariajgrimaldi This is ready for the final review, it'll be good if we could bump version and merge related edx-platform PR after requirements update before Redwood cut

wowkalucky commented 5 months ago

@mariajgrimaldi fixed.

mariajgrimaldi commented 5 months ago

@wowkalucky: could you please address this last comment? Thank you. I'll merge @ 11am est or once that's done.

openedx-webhooks commented 5 months ago

@kyrylo-kh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

mariajgrimaldi commented 5 months ago

v9.10.0 released! Thank you all.