Description: Use a new EVENTS_SERVICE_NAME setting to determine the source in EventsMetadata. Defaults to the old SERVICE_VARIANT setting if not set. SERVICE_VARIANT is usually only set on lms or cms, and has other uses, so it makes sense to have a new variable that all services can use for the events.
I didn't talk about how the EVENTS_SERVICE_NAME will be used to set the client id because that is Kafka specific.
Testing instructions:
pip install -e openedx-events
set EVENTS_SERVICE_NAME in your service settings
fire an event
check that the event source is openedx//web
Reviewers:
[ ] tag reviewer
[ ] tag reviewer
Merge checklist:
[ ] All reviewers approved
[ ] CI build is green
[ ] Version bumped
[ ] Changelog record added
[ ] Documentation updated (not only docstrings)
[ ] Commits are squashed
Post merge:
[ ] Create a tag
[ ] Check new version is pushed to PyPI after tag-triggered build is
finished.
[ ] Delete working branch (if not needed anymore)
Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.
Description: Use a new EVENTS_SERVICE_NAME setting to determine the source in EventsMetadata. Defaults to the old SERVICE_VARIANT setting if not set. SERVICE_VARIANT is usually only set on lms or cms, and has other uses, so it makes sense to have a new variable that all services can use for the events.
I didn't talk about how the EVENTS_SERVICE_NAME will be used to set the client id because that is Kafka specific.
Testing instructions: pip install -e openedx-events set EVENTS_SERVICE_NAME in your service settings fire an event check that the event source is openedx//web
Reviewers:
Merge checklist:
Post merge:
Author concerns: List any concerns about this PR - inelegant solutions, hacks, quick-and-dirty implementations, concerns about migrations, etc.