Fix: Custom Elasticsearch Host

openedx / openedx-k8s-harmony

A Prototype Helm Chart for deploying multiple Open edX instances (via Tutor) onto a cluster.

GNU Affero General Public License v3.0

10 stars 14 forks source link

Fix: Custom Elasticsearch Host #49

Closed CodeWithEmad closed 11 months ago

CodeWithEmad commented 1 year ago

This will introduce:

New config: K8S_HARMONY_ELASTIC_HOST to have custom hosts.
Makefile: to follow other tutor plugins.
Support for python 3.11 and 3.12 added.
fixed tutor version to Palm release, so older versions (without multi tenant and other features can't install it)
Updated document (markdown issues was cleaned up and tutor-mfe on k8s removed)
Some cleanup with isort and black.

I guess we should mention in the documents that multi-tenant works on palm+

openedx-webhooks commented 1 year ago

Thanks for the pull request, @CodeWithEmad! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

e0d commented 1 year ago

@CodeWithEmad I notice there are some commit-lint failures. Please note that we use conventional commits across Open edX projects. You can read about the details here. Can you please amend your commit messages to follow our standard?

CodeWithEmad commented 1 year ago

Sure. Thanks for the reminder 🙂

itsjeyd commented 1 year ago

Hey @CodeWithEmad, thank you for this contribution! The build is green so we should be good to move forward with engineering review.

@gabor-boros When you get a minute, could you post an update about when you'd be able to review this PR?

gabor-boros commented 1 year ago

@itsjeyd I just allowed the workflow pipelines to run, but I had no intention to review the PR. If there is a need for a reviewer, I can take the review tho.

gabor-boros commented 1 year ago

FTR: Set myself as a reviewer.

itsjeyd commented 1 year ago

Thanks for taking the review @gabor-boros! For next time, are there other people with merge rights to this repo that I could have pinged?

gabor-boros commented 1 year ago

I guess MoisesGSalas, jfavellar90, bradenmacdonald, felipemontoya, cmltaWt0 all have merge rights though I didn't confirm

openedx-webhooks commented 11 months ago

@CodeWithEmad 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.