Closed gabor-boros closed 9 months ago
Thanks for the pull request, @gabor-boros! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
@gabor-boros I'm assuming you'll coordinate with other CCs/maintainers about getting a review, but let me know if I can help with that in any way.
@gabor-boros could you please rebase your changes? Please let me know to jump right into the review :)
@jfavellar90 The PR is rebased now. You can progress with the review 😊
@gabor-boros 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
Description
This PR adds the prometheus-stack Helm chart as a dependency to monitor the cluster, closing #37 and #38. The stack is crafted by Prometheus.
The default values are disabling Prometheus and Grafana, so if one only needs Prometheus but not Grafana, no extra steps are necessary.
An example configuration for the chart (by the end user) could be
Testing
prometheusstack.enabled = false
(not that it isfalse
)grafana.<YOUR DOMAIN>
and login withadmin/prom-operator
OR: navigate to https://grafana.se6017.opencraft.hosting and continue from step 6.
Default Grafana password
Admin password is not pre-generated, because it is not picked up by the grafana pod yet -- this is a bug on their end. For more information, visit: https://github.com/prometheus-community/helm-charts/issues/3679
Author notes
This PR introduces
clusterDomain
which is a new Harmony chart-specific setting. At the moment, we use it for theNOTES.txt
andecho
's ingress. However, this could be used later with other templates in the chart.Why not using the
{{ .Values.clusterDomain }}
or{{ tpl (.Values.clusterDomain | toYaml) . }}
in thevalues.yaml
? Simply put, we can't. It won't be parsed.