Closed gabor-boros closed 8 months ago
Thanks for the pull request, @gabor-boros! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
Thanks for the pull request, @gabor-boros! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
Thanks for the pull request, @gabor-boros! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
@gabor-boros 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
The NOTES.txt currently missing a closing
end
for anif
statement in the Go template, making it broken and preventing the helm chart to be installed. This PR adds the missing{{ end }}
to close the initial{{ if and .Values.prometheusstack.grafana.enabled ... }}
statement.To check the issue, run the following: https://go.dev/play/p/dakeHH1Mrq5 Then to check the fix: https://go.dev/play/p/APXiGU29pci
The difference between the two is the above-mentioned closing tag.